New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings and helpers for prompt='consent'. #572

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
3 participants
@theacodes
Member

theacodes commented Jul 27, 2016

Fixes #453

This is the last one for 3.0.0. After this, I'll send the release PR.

:)

@nathanielmanistaatgoogle

This comment has been minimized.

Show comment
Hide comment
@nathanielmanistaatgoogle

nathanielmanistaatgoogle Jul 27, 2016

Contributor

First pass completed.

Contributor

nathanielmanistaatgoogle commented Jul 27, 2016

First pass completed.

@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jul 27, 2016

Member

@nathanielmanistaatgoogle this should be ready for another look. I was going to wait on travis but it seems we've been put back in the slow lane.

Member

theacodes commented Jul 27, 2016

@nathanielmanistaatgoogle this should be ready for another look. I was going to wait on travis but it seems we've been put back in the slow lane.

@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jul 27, 2016

Member

Travis is (finally) green. :)

Member

theacodes commented Jul 27, 2016

Travis is (finally) green. :)

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 7b364c2 into googleapis:master Jul 27, 2016

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jul 27, 2016

Member

Thanks for all the reviews today, @nathanielmanistaatgoogle. I'll be cutting 3.0.0 tomorrow morning.

Member

theacodes commented Jul 27, 2016

Thanks for all the reviews today, @nathanielmanistaatgoogle. I'll be cutting 3.0.0 tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment