This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Remove distinction between http AND http.request #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonparrott I think you should give this a once-over to make sure we're on the same page here. |
|
@dhermes I think this is fine. Your next step is to make the http arg optional for all of these? Or would you prefer to go ahead and remove the http arg altogether as the next step? |
This was referenced Aug 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #128.
It's unclear why
http_requestwas passed around instead ofhttp, other than possible to make mocking easier, but it became a rampant pattern.