This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Switch from pickle to jsonpickle #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +35,8 @@ | |||
| from oauth2client.contrib.django_util import get_storage | |||
| from oauth2client.contrib.django_util import signals | |||
|
|
|||
| import jsonpickle | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| from six.moves.urllib import parse | ||
|
|
||
| from oauth2client import client | ||
| from oauth2client.contrib import django_util | ||
| from oauth2client.contrib.django_util import get_storage | ||
| from oauth2client.contrib.django_util import signals | ||
|
|
||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -180,9 +181,10 @@ def test_callback_works(self, pickle): | |||
| self.assertEqual( | |||
| response.status_code, django.http.HttpResponseRedirect.status_code) | |||
| self.assertEqual(response['Location'], self.RETURN_URL) | |||
| jsonpickle_mock.decode.assert_called_once_with(pickled_flow) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. I'll let someone else have a pass first before merging |
|
@jonparrott hey, i just met you, and this is crazy, but LGTM, so merge me maybe? |
|
:D I never get to use any Carly Rae Jepsen gifs.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #594. As the reporter mentions the PickleSerializer is not recommended. The flow object can't be encoded with
json.dumps, we could add a custom serializer but this jsonpickle library seems to work and is super simple so figured I would try that./cc @huwshimi