This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fix django authorization redirect by correctly checking validity of credentials #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waprin
force-pushed
the
django_bugfix
branch
from
979e6ec
to
656f94a
Compare
theacodes
approved these changes
Sep 16, 2016
|
@waprin looks like we have a coverage miss: Can you fix? |
theacodes
changed the title
|
Yep fixing now |
waprin
force-pushed
the
django_bugfix
branch
2 times, most recently
from
e90d961
to
e9ae1f8
Compare
|
@jonparrott Looks like all my tests pass and django_util now has 100% coverage, failing on cover because of other code I think? |
|
Ah never mind, now I see still some missing lines in the tests themselves |
waprin
force-pushed
the
django_bugfix
branch
from
e9ae1f8
to
cfe40c0
Compare
waprin
force-pushed
the
django_bugfix
branch
from
cfe40c0
to
561039d
Compare
| @@ -170,21 +170,22 @@ def oauth2_authorize(request): | |||
| A redirect to Google OAuth2 Authorization. | |||
| """ | |||
| return_url = request.GET.get('return_url', None) | |||
| if not return_url: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking for credentials but I need to use the
has_credentialsmethod for cases of existing but invalid credentials.