New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 #17
Conversation
Namespace change has been LGTM'd |
I'd prefer you actually create and put the code in that namespace. (i.e. move the code into Is the goal to split the generated layer from handwritten bits? |
That is the goal, I'll let @dizcology follow up with a suggestion/decision. |
@software-dov could you point us to an example of setting namespace and name (https://github.com/googleapis/gapic-generator-python/blob/master/gapic/generator/options.py#L35-L36) through the GAPICMicrogenerator (https://github.com/googleapis/synthtool/blob/0762e8ee2ec21cdfc4d82020b985a104feb0453b/synthtool/gcp/gapic_microgenerator.py#L34)? |
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (#28) * clean up docstrings that are not rendered properly in reference doc (#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (googleapis#28) * clean up docstrings that are not rendered properly in reference doc (googleapis#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (googleapis#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (googleapis#28) * clean up docstrings that are not rendered properly in reference doc (googleapis#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (googleapis#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
DO NOT MERGE until confirmed about the approach.
Current user code (which will be broken after this change):
Expected user code after this change:
or