Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAPIC namespace #20

Merged
merged 3 commits into from Oct 2, 2020
Merged

GAPIC namespace #20

merged 3 commits into from Oct 2, 2020

Conversation

dizcology
Copy link
Contributor

@dizcology dizcology commented Oct 2, 2020

DO NOT MERGE until confirmed about the approach.

Current user code (which will be broken after this change):

from google.cloud import aiplatform
dataset = aiplatform.Dataset(...)

Expected user code after this change:

from google.cloud import aiplatform
dataset = aiplatform.gapic.Dataset(...)
# also works: dataset = aiplatform.gapic.v1beta1.Dataset(...)

@dizcology dizcology added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 2, 2020
@dizcology dizcology requested a review from a team as a code owner October 2, 2020 19:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@dizcology dizcology merged commit 7e83ff6 into googleapis:master Oct 2, 2020
sasha-gitg added a commit that referenced this pull request Oct 5, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
busunkim96 added a commit that referenced this pull request Oct 20, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (#28)

* clean up docstrings that are not rendered properly in reference doc (#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants