Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 1.54.0 #76

Merged
merged 1 commit into from
Dec 7, 2021
Merged

chore: release 1.54.0 #76

merged 1 commit into from
Dec 7, 2021

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Nov 19, 2021 •
edited
Loading

🤖 I have created a release *beep* *boop*

1.54.0 (2021-12-07)

Features

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner November 19, 2021 18:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@busunkim96
Copy link
Contributor

@parthea Please help merge this for @atulep in December.

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2021
vam-google
vam-google approved these changes Dec 7, 2021
View reviewed changes
Copy link

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2021
@hkdevandla
Copy link
Member

Changes in this release aren't specific to REGAPIC or not related to REGAPIC at all but it has dynamic routing changes that seems to impact overall cloud client libraries. If that's the case, we should consider holding off releasing this until the freeze is lifted.

@software-dov software-dov mentioned this pull request Dec 7, 2021
Merged
@software-dov
Copy link

@hkdevandla to clarify, the release adds four files: routing.proto, extended_operations.proto, and their *_pb2.py counterparts. These are pure additions to exported protobuf messages: there are no logic changes or test changes. This should absolutely be a safe release to make under the current guidelines.

@hkdevandla
Copy link
Member

Thanks for clarifying, Dov. LGTM to release in that case.

@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5b25ba3 into main Dec 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the release-v1.54.0 branch December 7, 2021 22:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2021
@yoshi-automation
Copy link
Contributor

Release is at https://github.com/googleapis/python-api-common-protos/releases/tag/v1.54.0

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

Assignees
No one assigned
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@busunkim96 @hkdevandla @software-dov @yoshi-automation @vam-google @parthea @yoshi-kokoro