TST: configure CircleCI #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CircleCI for testing pandas-gbq. This configuration uses the canonical Python and miniconda3 Docker images to reduce problems caused by a unique configuration. Also: * Re-enables conda tests. * Adds Python 3.7 tests.
|
Tests with credentials: https://circleci.com/gh/tswast/pandas-gbq/tree/issue228-circle |
|
This looks great!! Thanks! It looks like CircleCI links to builds under @tswast , rather than pydata. That's excellent: it'll test under the committer's credentials (IIRC Travis wouldn't run integration tests on PRs) It looks like it's not running properly under pydata. I can't seem to change this, I think because I'm a member but not an admin, is that right?
|
|
I think the 1.0 message will go away once this is merged. I see that there was a configuration option to turn on builds (but not share secrets for security) on pull requests. I've just enabled that option, so future PRs should build (without credentials) on CircleCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CircleCI for testing pandas-gbq. This configuration uses the
canonical Python and miniconda3 Docker images to reduce problems caused
by a unique configuration.
Also:
Edit: Conda build still fails #189
Closes #228 #197