Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python37 #206

Closed
wants to merge 16 commits into from
Closed

Test on Python37 #206

wants to merge 16 commits into from

Conversation

max-sixty
Copy link
Contributor

What do you think about skipping conda tests for the moment @tswast ?

The test on 3.7 seems less controversial (probably should split these up, but both small PRs)

@max-sixty max-sixty requested a review from tswast August 30, 2018 19:30
.travis.yml Show resolved Hide resolved
Copy link

@stickler-ci stickler-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files do not match the black styleguide:

  • nox.py

Copy link

@stickler-ci stickler-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files do not match the black styleguide:

  • nox.py

@max-sixty
Copy link
Contributor Author

@tswast let me know if you recognize these ADC errors in the 3.7 build: https://travis-ci.org/max-sixty/pandas-gbq/jobs/422752133

Could they be related to us using sudo (which is required for 3.7 it seems)?

@tswast
Copy link
Collaborator

tswast commented Aug 31, 2018

http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/?recursive=true from the Google Compute Enginemetadata service. Status: 404 Response

I think this is related to the fact that Travis CI runs on GCE but it locks down access to APIs. Maybe google-auth doesn't account for this case?

@max-sixty max-sixty changed the title Test on Python37 & Skip conda tests Test on Python37 Sep 1, 2018
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's

  • Sync to master
  • Make sure we include a Python 3.6 build, still.

I think syncing to master should pick up the fix for #226, which looks like the same reason that the Python 3.7 build was failing here.

@tswast
Copy link
Collaborator

tswast commented Nov 5, 2018

Python 3.7 builds added in #232

@tswast tswast closed this Nov 5, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants