ENH: deprecate private_key argument #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument was already deprecated in the function docs. This commit adds a warning when using pandas 0.24 or greater (the first version to include the credentials argument).
|
Tests running at https://circleci.com/gh/tswast/pandas-gbq/57 |
|
Superb! Thanks |
max-sixty
approved these changes
Dec 20, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument was already deprecated in the function docs. This commit
adds a warning when using pandas 0.24 or greater (the first version to
include the credentials argument).
Towards #161
Also, I add imports in the auth how-to guide towards #239 since I link to
that how-to in the warning text.