Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrading the ci/cd pipeline to reduce turnover time. #783

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

chalmerlowe
Copy link
Collaborator

Fixes #778 🦕

@chalmerlowe chalmerlowe requested review from a team as code owners June 10, 2024 17:08
@chalmerlowe chalmerlowe requested a review from tswast June 10, 2024 17:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 10, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jun 10, 2024
@Linchin
Copy link
Contributor

Linchin commented Jun 10, 2024

QUESTION / BLOCKER:

Thanks for making ci/cd more efficient! Just to double check, are we getting rid of pre-release tests altogether? Also owlbot added something. I'm not sure if this came from some new internal change, or we need to change owlbot.py.

@chalmerlowe
Copy link
Collaborator Author

QUESTION / BLOCKER:

Thanks for making ci/cd more efficient! Just to double check, are we getting rid of pre-release tests altogether?

There were two versions of prerelease testing.

  • prerelease (this one is intended to remain)
  • prerelease-deps (this was basically a duplicate AND it never runs (because it is not part of the google3 configuration setup) so I attempted to delete it.

Also owlbot added something. I'm not sure if this came from some new internal change, or we need to change owlbot.py.

I looked at the owlbot commit.

  • It added back in the prerelease-deps file that I deleted. I will go fix that.
  • AND it cleaned up a line spacing issue.

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2024
@Linchin
Copy link
Contributor

Linchin commented Jun 11, 2024

LGTM. Thank you!

@Linchin Linchin merged commit 99b51fd into main Jun 11, 2024
26 checks passed
@Linchin Linchin deleted the clowe-upgrade-ci-cd branch June 11, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: revise the CI/CD pipeline functionality in configs and noxfile
3 participants