Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add always_use_jwt_access #223

Merged
merged 3 commits into from Jul 1, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jun 29, 2021

fix: disable always_use_jwt_access

Committer: @busunkim96
PiperOrigin-RevId: 382142900

Source-Link: googleapis/googleapis@513440f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0

@gcf-owl-bot gcf-owl-bot bot requested review from as code owners Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot requested review from tswast and removed request for Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jun 29, 2021
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run label Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jun 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 29, 2021
@parthea parthea changed the title chore: use gapic-generator-python 0.50.3 fix: disable always_use_jwt_access Jun 30, 2021
@parthea parthea added kokoro:run kokoro:force-run labels Jun 30, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Jun 30, 2021
Copy link
Contributor

@tswast tswast left a comment

Getting a bunch of failures in the unit-3.7 session.

>           return grpc.secure_channel(target, composite_credentials, **kwargs)
E           TypeError: secure_channel() got an unexpected keyword argument 'default_scopes'

I suspect there needs to be a bump to the minimum versions somewhere (grpcio?)

@busunkim96 busunkim96 changed the title fix: disable always_use_jwt_access feat: add always_use_jwt_access Jun 30, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jun 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 30, 2021
@busunkim96 busunkim96 requested a review from tswast Jun 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jun 30, 2021
tswast
tswast approved these changes Jul 1, 2021
@tswast tswast merged commit fd82417 into master Jul 1, 2021
10 checks passed
@tswast tswast deleted the owl-bot-ea4f74f1-082b-465b-9597-a47a135ab1d2 branch Jul 1, 2021
@tswast
Copy link
Contributor

@tswast tswast commented Jul 1, 2021

Thanks for the fix @busunkim96 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants