-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add always_use_jwt_access #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: disable always_use_jwt_access Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: googleapis/googleapis-gen@7b1e2c3
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jun 29, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 29, 2021
product-auto-label
bot
added
the
api: bigquerystorage
Issues related to the googleapis/python-bigquery-storage API.
label
Jun 29, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 29, 2021
trusted-contributions-gcf
bot
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 29, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 29, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 29, 2021
parthea
changed the title
chore: use gapic-generator-python 0.50.3
fix: disable always_use_jwt_access
Jun 30, 2021
parthea
approved these changes
Jun 30, 2021
parthea
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jun 30, 2021
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jun 30, 2021
tswast
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a bunch of failures in the unit-3.7
session.
> return grpc.secure_channel(target, composite_credentials, **kwargs)
E TypeError: secure_channel() got an unexpected keyword argument 'default_scopes'
I suspect there needs to be a bump to the minimum versions somewhere (grpcio?)
busunkim96
changed the title
fix: disable always_use_jwt_access
feat: add always_use_jwt_access
Jun 30, 2021
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jun 30, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 30, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 30, 2021
tswast
approved these changes
Jul 1, 2021
Thanks for the fix @busunkim96 ! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.6.0](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.5.0...v2.6.0) (2021-07-09) ### Features * `read_session` optional to `ReadRowsStream.rows()` ([#228](https://www.github.com/googleapis/python-bigquery-storage/issues/228)) ([4f56029](https://www.github.com/googleapis/python-bigquery-storage/commit/4f5602950a0c1959e332aa2964245b9caf4828c8)) * add always_use_jwt_access ([#223](https://www.github.com/googleapis/python-bigquery-storage/issues/223)) ([fd82417](https://www.github.com/googleapis/python-bigquery-storage/commit/fd824174fb044fbacc83c647f619fda556333e26)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/python-bigquery-storage API.
cla: yes
This human has signed the Contributor License Agreement.
owl-bot-copy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: disable always_use_jwt_access
Committer: @busunkim96
PiperOrigin-RevId: 382142900
Source-Link: googleapis/googleapis@513440f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0