chore: change default retry policies timeouts (via synth) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
plamut
added
type: process
tswast
approved these changes
Sep 14, 2020
|
|
||
|
|
||
| # This class is part of an EXPERIMENTAL API. | ||
| class BigQueryRead(object): |
There was a problem hiding this comment.
Do we know what these new objects are about? Seems like a grpc stub. Does it affect the client objects?
There was a problem hiding this comment.
I don't, as I'm not really that familiar with BQ storage. It's the same thing that can be seen in other autogen PRs, though, and at least one of them has been approved back then, thus I assume it's fine.
There was a problem hiding this comment.
Ok 👍
Since the tests are passing, I assume we're good to go.
This was referenced Sep 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regenerates the code with latest changes, as several existing PRs (#52, #48, and #43) seem quite dated now.
The aim is to clean up the currently open PRs, make one last Python 2 compatible release, and then proceed with the migration to microgenerator.