Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use getQueryResults from DB-API #375

Merged
merged 1 commit into from Nov 10, 2020
Merged

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Nov 6, 2020

I suspect list_rows (tabledata.list) was being called directly
due to no page_size parameter on QueryJob.result at the time.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #362 馃

I suspect `list_rows` (`tabledata.list`) was being called directly
due to no `page_size` parameter on `QueryJob.result` at the time.
@tswast tswast requested a review from as a code owner Nov 6, 2020
@tswast tswast requested a review from pmakani Nov 6, 2020
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@tswast tswast mentioned this pull request Nov 6, 2020
7 tasks
@tswast tswast requested review from steffnay and removed request for pmakani Nov 6, 2020
@steffnay steffnay merged commit 30de15f into googleapis:master Nov 10, 2020
10 checks passed
Loading
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 12, 2020
The `is_dml` logic is not needed now that we moved to `getQueryResults` instead of `tabledata.list` (#375).

Previously, the destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries. 

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Towards #377  馃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants