Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a larger chunk size when loading data #799

Merged
merged 3 commits into from Jul 22, 2021
Merged

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented Jul 22, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/google-resumable-media-python#238 馃

@jimfulton jimfulton changed the title The chunk size used for data uploads was too small (1MB). Now it's 10鈥 fix: The chunk size used for data uploads was too small Jul 22, 2021
@jimfulton jimfulton marked this pull request as ready for review Jul 22, 2021
@jimfulton jimfulton requested review from as code owners Jul 22, 2021
@jimfulton jimfulton requested review from stephaniewang526 and removed request for Jul 22, 2021
@tswast tswast mentioned this pull request Jul 22, 2021
@tswast tswast changed the title fix: The chunk size used for data uploads was too small fix: use a larger chunk size when loading data Jul 22, 2021
tswast
tswast approved these changes Jul 22, 2021
Copy link
Contributor

@tswast tswast left a comment

Thanks!

Loading

@tswast tswast merged commit b804373 into master Jul 22, 2021
13 checks passed
Loading
@tswast tswast deleted the riversnake-fix-chunk-size branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants