This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 7, 2021
product-auto-label
bot
added
api: contactcenterinsights
Issues related to the googleapis/python-contact-center-insights API.
samples
Issues that are directly related to samples.
labels
Sep 7, 2021
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
TrucHLe
requested review from
nicain and
busunkim96
and removed request for
telpirion
September 13, 2021 15:37
TrucHLe
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 21, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 21, 2021
busunkim96
approved these changes
Sep 23, 2021
samples/snippets/create_analysis.py
Outdated
analysis_operation = insights_client.create_analysis( | ||
parent=conversation_name, analysis=analysis | ||
) | ||
analysis = analysis_operation.result(timeout=600000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same nit as in the other PR, the timeout seems a bit high to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops great catch! I updated this timeout to 24 hours.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: contactcenterinsights
Issues related to the googleapis/python-contact-center-insights API.
cla: yes
This human has signed the Contributor License Agreement.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #16 馃