Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

samples: create analysis #44

Merged
merged 8 commits into from Sep 23, 2021
Merged

Conversation

TrucHLe
Copy link
Contributor

@TrucHLe TrucHLe commented Sep 7, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #16 馃

@TrucHLe TrucHLe requested review from a team as code owners September 7, 2021 19:52
@TrucHLe TrucHLe requested a review from parthea September 7, 2021 19:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@product-auto-label product-auto-label bot added api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. samples Issues that are directly related to samples. labels Sep 7, 2021
@snippet-bot
Copy link

snippet-bot bot commented Sep 7, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@TrucHLe TrucHLe removed the request for review from parthea September 7, 2021 19:53
@TrucHLe TrucHLe changed the title samples: create_analysis samples: create analysis Sep 8, 2021
@TrucHLe TrucHLe requested review from nicain and busunkim96 and removed request for telpirion September 13, 2021 15:37
@TrucHLe TrucHLe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2021
@TrucHLe TrucHLe assigned nicain and unassigned nicain Sep 21, 2021
analysis_operation = insights_client.create_analysis(
parent=conversation_name, analysis=analysis
)
analysis = analysis_operation.result(timeout=600000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same nit as in the other PR, the timeout seems a bit high to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops great catch! I updated this timeout to 24 hours.

@TrucHLe TrucHLe merged commit 04ae533 into googleapis:main Sep 23, 2021
@TrucHLe TrucHLe deleted the create_analysis branch September 23, 2021 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample for analyzing a conversation
4 participants