Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): add missing method for system test with emulator #19

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards bigtable-5

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020
@crwilcox
Copy link
Contributor

crwilcox commented Apr 2, 2020

Where is the code that uses this?

@HemangChothani
Copy link
Contributor Author

Here method has called but implementation was not there.

def tearDownClass(cls):
# In the emulator, destroy the query entities.
if os.getenv(GCD_DATASET) is not None:
# Use the client for this test instead of the global.
clear_datastore.remove_all_entities(client=cls.CLIENT)

@crwilcox
Copy link
Contributor

crwilcox commented Apr 7, 2020

Have you validated this locally, or would this run in ci? I ask as delete_multi can only take so many keys at once.

@HemangChothani
Copy link
Contributor Author

I have validate locally, it works fine and delete all the keys.

@crwilcox crwilcox merged commit bf8b897 into googleapis:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants