samples: Add snippets for sum and avg

[jlara310]

Add sample snippets for sum and avg aggregation queries.

Two of these snippets depend on the following index:

indexes:

• kind: Task
  properties:
  • name: done
  • name: hours

I added samples/snippets/index.yaml to track the indexes required for the samples.

Fixes #479 🦕

[snippet-bot]

Here is the summary of changes.

You are about to add 5 region tags.

• samples/snippets/snippets.py:234, tag datastore_sum_aggregation_query_on_kind
• samples/snippets/snippets.py:260, tag datastore_sum_aggregation_query_with_filters
• samples/snippets/snippets.py:295, tag datastore_avg_aggregation_query_on_kind
• samples/snippets/snippets.py:321, tag datastore_avg_aggregation_query_with_filters
• samples/snippets/snippets.py:356, tag datastore_multiple_aggregation_in_structured_query

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[daniel-sanche]

We discussed this offline, but please see if you can modify the index as part of the test setup

Let me know if you need any help with this

[jlara310]

@daniel-sanche

I added a test fixture to set up indexes but it's getting a permission error:

google.api_core.exceptions.PermissionDenied: 403 The caller does not have permission

[daniel-sanche]

@daniel-sanche

I added a test fixture to set up indexes but it's getting a permission error:

google.api_core.exceptions.PermissionDenied: 403 The caller does not have permission

Hmm, that's strange, because the service account has IndexAdmin permissions. And I can also see an audit log that looks like the operation was successful, and I see an index that looks like the one you created on datastore

I wonder what would happen if you removed the result() from admin_client.create_index(request).result()? It looks like it uses a separate rpc to get the operation status, I wonder if it's possible that is the one that is raising 403?

Or you could try catching the error to silence it for now, to see if the index you need was created properly

[jlara310]

You're right. The IndexAdmin role does not have permissions for operations. Removed the code that tries to wait for the operation.

[jlara310]

Only the Python 3.10 test failed. Perhaps the IndexAdmin role is missing for that project?

[daniel-sanche]

thanks, I opened a request to add the missing permission to that project

[daniel-sanche]

@jlara310 Ok, the permissions have been added and the tests are now passing!

[daniel-sanche]

Do datastore samples typically include this set-up part?

[jlara310]

Yes, as part of making samples copy-paste-runnable. This matches the style of the Java and Python count() samples, for example.

[daniel-sanche]

Is there any significance to these numbers?

[jlara310]

They are randomly generated IDs from the Datastore console. A previous example used task1, task2, task3, but monotonically increasing IDs are an anti-pattern.

[daniel-sanche]

it might be worth either mentioning that in a comment, or even using random.random() to generate them in the sample if that would make sense in the context of the code

[jlara310]

Good point. Updated the code to let client generate the IDs and added a comment about it.