Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systests are being skipped on Kokoro #160

Closed
tseaver opened this issue Aug 20, 2020 · 0 comments · Fixed by #161 or #164
Closed

Systests are being skipped on Kokoro #160

tseaver opened this issue Aug 20, 2020 · 0 comments · Fixed by #161 or #164
Assignees
@tseaver
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2020

The systests expect to have FIRESTORE_APPLICATION_CREDENTIALS set, but the templated .kokoro/build.sh is setting only the more normal GOOGLE_APPLICATION_CREDENTIALS. The monorepo .kokoro/build.sh set both.
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Aug 20, 2020
@tseaver tseaver self-assigned this Aug 20, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 20, 2020
tseaver added a commit that referenced this issue Aug 20, 2020
@tseaver
tests: run systests on Kokoro
3b5892c 
Closes #160
@tseaver tseaver mentioned this issue Aug 20, 2020
Merged
tseaver added a commit that referenced this issue Aug 20, 2020
@tseaver
tests: run systests on Kokoro
e0917bc 
Closes #160
@tseaver tseaver mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the googleapis/python-firestore API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
1 participant
@tseaver