Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firestore): on_snapshot document changes #27

Closed

Conversation

HemangChothani
Copy link
Contributor

Fixes #26

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2020
@HemangChothani HemangChothani changed the title Firestore issue 26 docs(firestore): on_snapshot document changes Mar 17, 2020
@BenWhitehead BenWhitehead requested review from tseaver and removed request for BenWhitehead March 17, 2020 18:59
@BenWhitehead
Copy link
Collaborator

@crwilcox or @tseaver Can either of you review this? I'm not familiar with pythons type annotations.

@crwilcox
Copy link
Contributor

@HemangChothani can you update this branch?

Also, not sure why this change is being made? It seems to edit actual types of functions, not just the annotations.

@crwilcox
Copy link
Contributor

#79 opened with me merging master. Thanks!

@crwilcox crwilcox closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent type annotations for Document.on_snapshot
4 participants