#216 implement _prepare_for_put for nested entities #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chmoder
changed the title
chmoder
changed the title
|
Hi, thanks for taking the time to submit this. Instead of using this, I wound up going back to the original implementation and reused the code from there. See #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested entities(
LocalStructuredProperty,StructuredProperty) with properties that require_prepare_for_putdon't get called whenput()gets called.I found that when saving an entity
_prepare_for_putgets called. But when a nested property is part of that entity, its' properties don't get "prepared for put". The solution I chose was to extend that functionality to an entities, nested entities