Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): allow file path for credentials #221

Merged
merged 5 commits into from Mar 10, 2021

Conversation

HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 2, 2021

Fixes #220

@HemangChothani HemangChothani requested review from larkee and c24t Feb 2, 2021
@HemangChothani HemangChothani requested a review from as a code owner Feb 2, 2021
@product-auto-label product-auto-label bot added the api: spanner label Feb 2, 2021
@google-cla google-cla bot added the cla: yes label Feb 2, 2021
Copy link
Contributor

@larkee larkee left a comment

LGTM, although I'm a little concerned about having both a credentials and a credentials_uri kwarg for the same method. Did you consider any alternatives?

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Feb 8, 2021

@larkee Yes i think, If we combine credentials and credentials_uri and make conditions on Object and string but it would be little bit confusing.
Need to change in doc of django_spanner accordingly.

Copy link
Contributor

@larkee larkee left a comment

Just some minor doc changes to try minimize confusion

@@ -356,7 +356,9 @@ def connect(
:type credentials: :class:`~google.auth.credentials.Credentials`
Copy link
Contributor

@larkee larkee Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:type credentials: :class:`~google.auth.credentials.Credentials`
:type credentials: Union[:class:`~google.auth.credentials.Credentials`, str]

@@ -356,7 +356,9 @@ def connect(
:type credentials: :class:`~google.auth.credentials.Credentials`
:param credentials: (Optional) The authorization credentials to attach to
requests. These credentials identify this application
to the service. If none are specified, the client will
to the service. Or a string specifying (path) where to retrieve
Copy link
Contributor

@larkee larkee Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

(Optional) The authorization credentials to attach to 
requests. These credentials identify this application 
to the service. These credentials may be specified as 
a file path indicating where to retrieve the service 
account JSON for the credentials to connect to 
Cloud Spanner. If none are specified, the client will 
attempt to ascertain the credentials from the 
environment.

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Mar 3, 2021

System test failed with error google.api_core.exceptions.ResourceExhausted: 429 Project 1065521786570 cannot add 1 nodes in region us-central1. not related to changes.

@HemangChothani HemangChothani added the kokoro:force-run label Mar 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 3, 2021
larkee
larkee approved these changes Mar 10, 2021
@larkee larkee changed the title fix: credentials_uri parameter error fix(db_api): allow file path for credentials Mar 10, 2021
@larkee larkee merged commit 1de0284 into googleapis:master Mar 10, 2021
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://www.github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25)


### Features

* add encryption_info to Database ([#284](https://www.github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://www.github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435))
* add support for CMEK ([#105](https://www.github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://www.github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0))
* add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://www.github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://www.github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d))
* added retry and timeout params to partition read in database and snapshot class ([#278](https://www.github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://www.github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f))
* **db_api:** support executing several DDLs separated by semicolon ([#277](https://www.github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://www.github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8))


### Bug Fixes

* avoid consuming pending null values when merging ([#286](https://www.github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://www.github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b))
* **db_api:** allow file path for credentials ([#221](https://www.github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://www.github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a))
* **db_api:** ensure DDL statements are being executed ([#290](https://www.github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://www.github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f))
* **db_api:** revert Mutations API usage ([#285](https://www.github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://www.github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c))


### Documentation

* fix docstring types and typos ([#259](https://www.github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://www.github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c))
* fix snapshot usage ([#291](https://www.github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://www.github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants