Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass gRPC config options to gRPC channel creation #26

Merged
merged 2 commits into from Apr 17, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Feb 27, 2020

Currently the gRPC config options in spanner.grpc.config are not being used at all. There are changes being made by the synth file but they are generating an unused variable. This PR makes use of this variable to pass the config options through to the gRPC channel creation.

Fixes #6

@larkee larkee requested review from tseaver and crwilcox Feb 27, 2020
@googlebot googlebot added the cla: yes label Feb 27, 2020
Copy link

@hengfengli hengfengli left a comment

LGTM.

@larkee larkee merged commit 6c9a1ba into googleapis:master Apr 17, 2020
3 checks passed
@larkee larkee deleted the grpc-config-fix branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants