Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for JSON type #353

Merged
merged 22 commits into from Aug 26, 2021
Merged

Conversation

asthamohta
Copy link
Contributor

@asthamohta asthamohta commented May 19, 2021

feat: add support for JSON type

@asthamohta asthamohta requested a review from as a code owner May 19, 2021
@product-auto-label product-auto-label bot added the api: spanner label May 19, 2021
@google-cla google-cla bot added the cla: yes label May 19, 2021
@asthamohta asthamohta requested review from vi3k6i5, larkee and zoercai May 19, 2021
@larkee larkee added the do not merge label May 21, 2021
zoercai
zoercai approved these changes Jun 4, 2021
Copy link
Contributor

@zoercai zoercai left a comment

LGTM for functionality in general and test examples, I'll leave the implementation/Python review to @larkee

larkee
larkee approved these changes Jun 11, 2021
Copy link
Contributor

@larkee larkee left a comment

LGTM 👍

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jul 5, 2021

@asthamohta we merged the code generation PR, so you should now be able to rebase and hopefully get rid of the generated code from the PR.

@zoercai zoercai added the kokoro:force-run label Aug 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 23, 2021
@zoercai zoercai removed the do not merge label Aug 23, 2021
@zoercai zoercai added kokoro:run kokoro:force-run and removed kokoro:run labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 24, 2021
@asthamohta asthamohta added kokoro:run kokoro:force-run labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Aug 24, 2021
@larkee larkee added the kokoro:force-run label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 24, 2021
@larkee larkee added the kokoro:force-run label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 24, 2021
@larkee larkee added the kokoro:force-run label Aug 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 25, 2021
@zoercai zoercai added the kokoro:force-run label Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 26, 2021
@larkee larkee merged commit b1dd04d into googleapis:master Aug 26, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants