Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout parameter to public methods #44

Merged
merged 10 commits into from Feb 11, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Feb 4, 2020

Closes #6.
Closes #13.

A replacement for the same PR in the old repo.

Notes

  • ACL._ensure_loaded() has a default timeout, but not all internal calls to it can be made that configurable, such as in ACL.__iter__(). I thus left that part to use a default timeout.
  • Blob.download_to_file(), Blob.upload_from_file(), and the methods that rely on these two do not expose timeouts, because the underlying resumable-media logic applies its own default timeout to transport.request(), which would override user timeouts.
    Getting around that would first require adding configurable timeouts to the resumable-media dependency (there is a PR #116 that adds these, but only for uploads and it's not merged yet) .

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut changed the title feat(storage): add timeout parameter to public methods feat: add timeout parameter to public methods Feb 4, 2020
@plamut
Copy link
Contributor Author

@plamut plamut commented Feb 11, 2020

System tests CI failure seems to be temporary (503 ServiceUnavailable).

@crwilcox crwilcox merged commit 63abf07 into googleapis:master Feb 11, 2020
3 checks passed
@plamut plamut deleted the iss-10199 branch Jun 15, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* Add a default request timeout constant

* Add timeout to ACL public methods

* Add timeout to Blob methods

* Add default timeout to Batch._do_request()

* Add timeout to Bucket methods

* Add timeout to Client methods

* Add timeout to HMACKeyMetadata methods

* Add timeout to BucketNotification methods

* Add timeout to _PropertyMixin helpers
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* Add a default request timeout constant

* Add timeout to ACL public methods

* Add timeout to Blob methods

* Add default timeout to Batch._do_request()

* Add timeout to Bucket methods

* Add timeout to Client methods

* Add timeout to HMACKeyMetadata methods

* Add timeout to BucketNotification methods

* Add timeout to _PropertyMixin helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants