Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove and replace deprecated function download_as_string() #508

Merged
merged 3 commits into from Jul 16, 2021
Merged

docs: remove and replace deprecated function download_as_string() #508

merged 3 commits into from Jul 16, 2021

Conversation

@richardevs
Copy link
Contributor

@richardevs richardevs commented Jul 15, 2021

Remove deprecated function download_as_string(), replace with download_as_bytes(). [1]
[1] https://github.com/googleapis/python-storage/blob/master/google/cloud/storage/blob.py#L138

Fixes #504 馃

@richardevs richardevs requested a review from Jul 15, 2021
@richardevs richardevs requested a review from as a code owner Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 15, 2021

@richardevs Thanks for the patch! Next time, you can edit the PR title to fix the CC check, or do a git commit --amend followed by git push -f.

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 16, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 8dfa4d4 into googleapis:master Jul 16, 2021
5 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants