fix: Add async context manager return types (#351)

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Jul 4, 2023 · ba48edc · ba48edc
1 parent 0711b88
commit ba48edc
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 201 deletions.
diff --git a/google/cloud/tasks_v2/services/cloud_tasks/async_client.py b/google/cloud/tasks_v2/services/cloud_tasks/async_client.py
@@ -2316,7 +2316,7 @@ async def sample_run_task():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "CloudTasksAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/google/cloud/tasks_v2beta2/services/cloud_tasks/async_client.py b/google/cloud/tasks_v2beta2/services/cloud_tasks/async_client.py
@@ -2865,7 +2865,7 @@ async def sample_run_task():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "CloudTasksAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/google/cloud/tasks_v2beta3/services/cloud_tasks/async_client.py b/google/cloud/tasks_v2beta3/services/cloud_tasks/async_client.py
@@ -2318,7 +2318,7 @@ async def sample_run_task():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "CloudTasksAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/tests/unit/gapic/tasks_v2/test_cloud_tasks.py b/tests/unit/gapic/tasks_v2/test_cloud_tasks.py
@@ -1105,9 +1105,11 @@ async def test_list_queues_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_queues(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -3932,9 +3934,11 @@ async def test_list_tasks_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_tasks(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -3965,9 +3969,6 @@ def test_get_task(request_type, transport: str = "grpc"):
             dispatch_count=1496,
             response_count=1527,
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.get_task(request)
 
@@ -4208,9 +4209,6 @@ def test_create_task(request_type, transport: str = "grpc"):
             dispatch_count=1496,
             response_count=1527,
             view=gct_task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.create_task(request)
 
@@ -4681,9 +4679,6 @@ def test_run_task(request_type, transport: str = "grpc"):
             dispatch_count=1496,
             response_count=1527,
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.run_task(request)
 
@@ -8372,9 +8367,6 @@ def test_get_task_rest(request_type):
             dispatch_count=1496,
             response_count=1527,
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -8649,9 +8641,6 @@ def test_create_task_rest(request_type):
             dispatch_count=1496,
             response_count=1527,
             view=gct_task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -9188,9 +9177,6 @@ def test_run_task_rest(request_type):
             dispatch_count=1496,
             response_count=1527,
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj

diff --git a/tests/unit/gapic/tasks_v2beta2/test_cloud_tasks.py b/tests/unit/gapic/tasks_v2beta2/test_cloud_tasks.py
@@ -1105,9 +1105,11 @@ async def test_list_queues_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_queues(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -1136,11 +1138,6 @@ def test_get_queue(request_type, transport: str = "grpc"):
         call.return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.get_queue(request)
 
@@ -1373,11 +1370,6 @@ def test_create_queue(request_type, transport: str = "grpc"):
         call.return_value = gct_queue.Queue(
             name="name_value",
             state=gct_queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.create_queue(request)
 
@@ -1620,11 +1612,6 @@ def test_update_queue(request_type, transport: str = "grpc"):
         call.return_value = gct_queue.Queue(
             name="name_value",
             state=gct_queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.update_queue(request)
 
@@ -2087,11 +2074,6 @@ def test_purge_queue(request_type, transport: str = "grpc"):
         call.return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.purge_queue(request)
 
@@ -2324,11 +2306,6 @@ def test_pause_queue(request_type, transport: str = "grpc"):
         call.return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.pause_queue(request)
 
@@ -2561,11 +2538,6 @@ def test_resume_queue(request_type, transport: str = "grpc"):
         call.return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
         response = client.resume_queue(request)
 
@@ -3962,9 +3934,11 @@ async def test_list_tasks_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_tasks(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -3993,9 +3967,6 @@ def test_get_task(request_type, transport: str = "grpc"):
         call.return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.get_task(request)
 
@@ -4228,9 +4199,6 @@ def test_create_task(request_type, transport: str = "grpc"):
         call.return_value = gct_task.Task(
             name="name_value",
             view=gct_task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.create_task(request)
 
@@ -5159,9 +5127,6 @@ def test_renew_lease(request_type, transport: str = "grpc"):
         call.return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.renew_lease(request)
 
@@ -5414,9 +5379,6 @@ def test_cancel_lease(request_type, transport: str = "grpc"):
         call.return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.cancel_lease(request)
 
@@ -5659,9 +5621,6 @@ def test_run_task(request_type, transport: str = "grpc"):
         call.return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
         response = client.run_task(request)
 
@@ -6232,11 +6191,6 @@ def test_get_queue_rest(request_type):
         return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -6539,11 +6493,6 @@ def test_create_queue_rest(request_type):
         return_value = gct_queue.Queue(
             name="name_value",
             state=gct_queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -6893,11 +6842,6 @@ def test_update_queue_rest(request_type):
         return_value = gct_queue.Queue(
             name="name_value",
             state=gct_queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -7451,11 +7395,6 @@ def test_purge_queue_rest(request_type):
         return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -7721,11 +7660,6 @@ def test_pause_queue_rest(request_type):
         return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -7991,11 +7925,6 @@ def test_resume_queue_rest(request_type):
         return_value = queue.Queue(
             name="name_value",
             state=queue.Queue.State.RUNNING,
-            app_engine_http_target=target.AppEngineHttpTarget(
-                app_engine_routing_override=target.AppEngineRouting(
-                    service="service_value"
-                )
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -9428,9 +9357,6 @@ def test_get_task_rest(request_type):
         return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -9701,9 +9627,6 @@ def test_create_task_rest(request_type):
         return_value = gct_task.Task(
             name="name_value",
             view=gct_task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -10778,9 +10701,6 @@ def test_renew_lease_rest(request_type):
         return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -11065,9 +10985,6 @@ def test_cancel_lease_rest(request_type):
         return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj
@@ -11349,9 +11266,6 @@ def test_run_task_rest(request_type):
         return_value = task.Task(
             name="name_value",
             view=task.Task.View.BASIC,
-            app_engine_http_request=target.AppEngineHttpRequest(
-                http_method=target.HttpMethod.POST
-            ),
         )
 
         # Wrap the value into a proper Response obj