Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub#findFilesByExtension is returning paths outside of the folder #1164

Closed
chingor13 opened this issue Dec 22, 2021 · 1 comment
Closed

GitHub#findFilesByExtension is returning paths outside of the folder #1164

chingor13 opened this issue Dec 22, 2021 · 1 comment
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

GoogleCloudPlatform/blueprints#82 is having issues because catalog/landing-zone-lite/iam.yaml is being returned in the file list for a search for catalog/landing-zone.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 22, 2021
@chingor13 chingor13 self-assigned this Dec 22, 2021
This was referenced Dec 22, 2021
Merged
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 22, 2021
@chingor13
fix: GitHub#findFilesByExtension should treat prefix as a directory (#…
8329825 
…1166)

Fixes #1164
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 22, 2021
@release-please
chore: release 12.6.3 (#1167)
2443539 
🤖 I have created a release \*beep\* \*boop\*
---
### [12.6.3](https://www.github.com/googleapis/release-please/compare/v12.6.2...v12.6.3) (2021-12-22)


### Bug Fixes

* GitHub#findFilesByExtension should treat prefix as a directory ([#1166](https://www.github.com/googleapis/release-please/issues/1166)) ([8329825](https://www.github.com/googleapis/release-please/commit/83298257a2021f88df4db3c95869955f8773eb70)), closes [#1164](https://www.github.com/googleapis/release-please/issues/1164)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@chingor13
Copy link
Contributor Author

Fixed in #1165 and #1166

@bharathkkb bharathkkb mentioned this issue Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chingor13