Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-workspace): maintain current version range prefix #1723

Merged
merged 4 commits into from Nov 3, 2022

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Oct 25, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@OrKoN OrKoN requested a review from a team as a code owner October 25, 2022 12:21
@OrKoN OrKoN requested a review from a team October 25, 2022 12:21
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 25, 2022
@OrKoN
Copy link
Contributor Author

OrKoN commented Oct 25, 2022

Hey, I have seen #1580 and saw a suggestion to maintain the current range prefix when doing a release. That would work for us in the Puppeteer project (currently, we rely on a custom script to pin dependencies that does not update the changelog). Let me know if you think this approach would make sense and I will look into improving test coverage (hints are welcome).

Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to start looking into #1580 again and noticed this PR 👍

You can copy the tests from #1580 and modify them slightly.
The current tests should fail anyway and also need probably fixing.

src/plugins/node-workspace.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 28, 2022
@OrKoN OrKoN force-pushed the maintain-range-prefix branch 4 times, most recently from b9dcb35 to c01eb07 Compare November 2, 2022 10:28
test/plugins/node-workspace.ts Outdated Show resolved Hide resolved
src/plugins/node-workspace.ts Show resolved Hide resolved
@chingor13 chingor13 merged commit 53e2599 into googleapis:main Nov 3, 2022
@OrKoN OrKoN deleted the maintain-range-prefix branch November 3, 2022 16:03
Copy link

@Daniel950502 Daniel950502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants