Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default php strategy and php-yoshi to match #2190

Closed
wants to merge 3 commits into from

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 5, 2024

address #2189

  • Have the same default configuration for conventional commits
  • Ensure "yoshi-php" strategy will also set the "version" field in composer.json if it exists

Question for @chingor13 - what does "hidden" mean in yoshi-php? What is the difference between hidden and omitting the entry entirely from CHANGELOG_SECTIONS in that context? It seems like those items don't show up in the release notes at all (for google-cloud-php releases)

@bshaffer bshaffer requested review from a team as code owners January 5, 2024 15:03
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 5, 2024
@bshaffer bshaffer changed the title feat: update default php strategies to match php-yoshi feat: update default php strategy and php-yoshi to match Jan 5, 2024
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -yoshi strategies are internal (no good way to separate right now), undocumented for the public (not meant for external users) and we can make behavior breaking changes whenever.

The non--yoshi strategies are in use by other teams and we should not make behavior breaking changes.

src/strategies/php.ts Outdated Show resolved Hide resolved
@chingor13
Copy link
Contributor

Question for @chingor13 - what does "hidden" mean in yoshi-php? What is the difference between hidden and omitting the entry entirely from CHANGELOG_SECTIONS in that context? It seems like those items don't show up in the release notes at all (for google-cloud-php releases)

I think this is an artifact of the initial implementation. We pass that config to the conventional changelog notes builder. I don't think there's a difference between hidden: true and omitted.

@bshaffer
Copy link
Contributor Author

bshaffer commented Jan 9, 2024

Opened #2192 instead

@bshaffer bshaffer deleted the strategies-php branch January 9, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants