fix(generated-files-bot): handle missing external manifest files #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
JustinBeckwith
approved these changes
Nov 3, 2020
| @@ -22,7 +22,7 @@ | |||
| "start": "probot run ./build/src/generated-files-bot.js", | |||
| "start:local": "node ./build/src/local.js", | |||
| "pretest": "npm run compile", | |||
| "test": "cross-env LOG_LEVEL=fatal c8 mocha --exit build/test", | |||
| "test": "cross-env LOG_LEVEL=fatal c8 mocha --exit build/test --timeout 10000", | |||
There was a problem hiding this comment.
I am generally not a fan of the longer timeout, but I will read ahead
There was a problem hiding this comment.
Talking with @bcoe, it sounds like octokit is retrying with backoff until a certain point limit. The test takes about 3 seconds to pass which was higher than the 2s timeout.
There was a problem hiding this comment.
Opened #1078 to help address this. I like the current typing in the current implementation (no casting to any), but the retry on the 404 means we might need to bump the test timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077
We should gracefully handle a missing external manifest and not crash. Logs a warning instead.