fix: comment, request params

googleapis · May 18, 2021 · a156256 · a156256
1 parent 98e24ce
commit a156256
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/test/integration/apis/kms/v1/cloudkms_test_mixins_v1.yaml b/test/integration/apis/kms/v1/cloudkms_test_mixins_v1.yaml
@@ -33,8 +33,7 @@ documentation:
   # Test the overriding of comments.
   - selector: google.iam.v1.IAMPolicy.TestIamPermissions
     description: |-
-      This is a different comment for TestIamPermissions in the yaml file
-      that should clobber the documentation in iam_policy.proto.
+      This is a different comment for TestIamPermissions in the yaml file that should clobber the documentation in iam_policy.proto.
 
 http:
   rules:

diff --git a/test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClient.java b/test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClient.java
@@ -3333,7 +3333,7 @@ public final UnaryCallable<GetLocationRequest, Location> getLocationCallable() {
 
   // AUTO-GENERATED DOCUMENTATION AND METHOD.
   /**
-   * This is a different comment for TestIamPermissions in the yaml filethat should clobber the
+   * This is a different comment for TestIamPermissions in the yaml file that should clobber the
    * documentation in iam_policy.proto.
    *
    * <p>Sample code:
@@ -3359,7 +3359,7 @@ public final TestIamPermissionsResponse testIamPermissions(TestIamPermissionsReq
 
   // AUTO-GENERATED DOCUMENTATION AND METHOD.
   /**
-   * This is a different comment for TestIamPermissions in the yaml filethat should clobber the
+   * This is a different comment for TestIamPermissions in the yaml file that should clobber the
    * documentation in iam_policy.proto.
    *
    * <p>Sample code:

diff --git a/test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClientTest.java b/test/integration/goldens/kms/com/google/cloud/kms/v1/KeyManagementServiceClientTest.java
@@ -76,12 +76,12 @@ public class KeyManagementServiceClientTest {
   @BeforeClass
   public static void startStaticServer() {
     mockKeyManagementService = new MockKeyManagementService();
-    mockLocations = new MockLocations();
     mockIAMPolicy = new MockIAMPolicy();
+    mockLocations = new MockLocations();
     mockServiceHelper =
         new MockServiceHelper(
             UUID.randomUUID().toString(),
-            Arrays.<MockGrpcService>asList(mockKeyManagementService, mockLocations, mockIAMPolicy));
+            Arrays.<MockGrpcService>asList(mockKeyManagementService, mockIAMPolicy, mockLocations));
     mockServiceHelper.start();
   }
 

diff --git a/test/integration/goldens/kms/com/google/cloud/kms/v1/stub/GrpcKeyManagementServiceStub.java b/test/integration/goldens/kms/com/google/cloud/kms/v1/stub/GrpcKeyManagementServiceStub.java
@@ -783,8 +783,8 @@ public Map<String, String> extract(GetIamPolicyRequest request) {
                   @Override
                   public Map<String, String> extract(ListLocationsRequest request) {
                     ImmutableMap.Builder<String, String> params = ImmutableMap.builder();
-                    params.put("display_name", String.valueOf(request.getDisplayName()));
-                    params.put("location_id", String.valueOf(request.getLocationId()));
+                    params.put("filter", String.valueOf(request.getFilter()));
+                    params.put("page_size", String.valueOf(request.getPageSize()));
                     return params.build();
                   }
                 })