-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Junit 4 to Junit 5: java-core #2726
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Comments
mpeddada1
added
type: cleanup
An internal cleanup or hygiene concern.
priority: p2
Moderately-important priority. Fix may not be included in next release.
labels
May 6, 2024
JoeWang1127
added
the
status: blocked
Resolving the issue is dependent on other work.
label
May 9, 2024
Some downstream libraries, e.g., java-logging, depend on a test class, We should keep these tests as-is. |
JoeWang1127
removed
the
status: blocked
Resolving the issue is dependent on other work.
label
May 10, 2024
JoeWang1127
added a commit
that referenced
this issue
May 16, 2024
Fix #2726. `BaseSerializationTest` will not migrate to Junit 5 because downstream libraries, e.g., java-logging, are extending this class and these libraries still use Junit 4. Migrating this class to Junit 5 will cause test failures in downstream libraries.
lqiu96
pushed a commit
that referenced
this issue
May 16, 2024
Fix #2726. `BaseSerializationTest` will not migrate to Junit 5 because downstream libraries, e.g., java-logging, are extending this class and these libraries still use Junit 4. Migrating this class to Junit 5 will cause test failures in downstream libraries.
lqiu96
pushed a commit
that referenced
this issue
May 22, 2024
Fix #2726. `BaseSerializationTest` will not migrate to Junit 5 because downstream libraries, e.g., java-logging, are extending this class and these libraries still use Junit 4. Migrating this class to Junit 5 will cause test failures in downstream libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
See this doc for important differences and benefits of Junit 5.
See the official doc from Junit5 for migration tips.
In general, for each and every unit test
org.junit.Assert.assertEquals
withorg.junit.jupiter.api.Assertions.assertEquals
.@Before
with@BeforeEach
@Test(expected = …)
withassertThrows
.See example PR that adds Junit 5 dependencies to gax-java and migrates one test to Junit5.
The text was updated successfully, but these errors were encountered: