Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline disclaimer comment, use Sample/RegionTag, collect GapicClass samples (pt 2) #934

Closed
wants to merge 19 commits into from

Conversation

eaball35
Copy link
Contributor

go/java-sample-gen

@eaball35 eaball35 requested review from a team as code owners February 15, 2022 03:51
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 15, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 15, 2022

Here is the summary of possible violations 😱

There are 125 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 126 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eaball35 eaball35 changed the title feat: inline disclaimer comment, use Sample/RegionTag, collect GapicClass samples feat: inline disclaimer comment, use Sample/RegionTag, collect GapicClass samples (pt 2) Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #934 (f919e8a) into main (03fba01) will decrease coverage by 0.49%.
The diff coverage is 91.27%.

❗ Current head f919e8a differs from pull request most recent head 1b595d3. Consider uploading reports for the commit 1b595d3 to get more accurate results

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   87.96%   87.46%   -0.50%     
==========================================
  Files         156      165       +9     
  Lines       16198    16729     +531     
  Branches     1179     1194      +15     
==========================================
+ Hits        14248    14632     +384     
- Misses       1608     1744     +136     
- Partials      342      353      +11     
Impacted Files Coverage Δ
...n/java/com/google/api/generator/ProtoRegistry.java 0.00% <0.00%> (ø)
...i/generator/engine/writer/ImportWriterVisitor.java 94.56% <ø> (+1.61%) ⬆️
...pic/composer/ClientLibraryPackageInfoComposer.java 0.00% <0.00%> (ø)
...mposer/samplecode/SampleCodeBodyJavaFormatter.java 100.00% <ø> (ø)
...er/samplecode/ServiceClientSampleCodeComposer.java 96.32% <88.38%> (-2.97%) ⬇️
...r/common/AbstractServiceSettingsClassComposer.java 97.57% <90.00%> (-0.15%) ⬇️
...mmon/AbstractServiceStubSettingsClassComposer.java 96.15% <90.00%> (-0.06%) ⬇️
...ser/common/AbstractServiceClientClassComposer.java 98.38% <90.90%> (-0.24%) ⬇️
...m/google/api/generator/gapic/model/GapicClass.java 97.50% <96.87%> (-2.50%) ⬇️
...ator/gapic/composer/samplecode/SampleComposer.java 97.80% <97.80%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6a02f...1b595d3. Read the comment docs.

@suztomo
Copy link
Member

suztomo commented Feb 24, 2022

"Region tag product prefix — Missing region tag prefix" failing. What is it?

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 27 Code Smells

91.8% 91.8% Coverage
1.6% 1.6% Duplication

@eaball35 eaball35 closed this Mar 15, 2022
@eaball35 eaball35 deleted the samplegen_pt2 branch March 15, 2022 21:29
suztomo pushed a commit that referenced this pull request Mar 21, 2023
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [certifi](https://togithub.com/certifi/python-certifi) | `==2022.9.14` -> `==2022.9.24` | [![age](https://badges.renovateapi.com/packages/pypi/certifi/2022.9.24/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/certifi/2022.9.24/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/certifi/2022.9.24/compatibility-slim/2022.9.14)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/certifi/2022.9.24/confidence-slim/2022.9.14)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMSIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4xIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28)


### Dependencies

* Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09))
* Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904))
* Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61))
* Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f))
* Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f))
* Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1))
* Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe))
* Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa))
* Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e))
* Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3))
* Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2))
* Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1))
* Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579))
* Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8))
* Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7))
* Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa))
* Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf))
* Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6))
* Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535))
* Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46))
* Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3))
* Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9))
* Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants