Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid using implicitly declared samples target in BUILD.bazel #994

Merged
merged 2 commits into from
May 21, 2022
Merged

chore: avoid using implicitly declared samples target in BUILD.bazel #994

merged 2 commits into from
May 21, 2022

Conversation

eaball35
Copy link
Contributor

@eaball35 eaball35 commented May 18, 2022 •
edited

Now to include samples in the package we have to pass include_samples = True in the build file such as:

java_gapic_assembly_gradle_pkg(
    name = "google-cloud-accessapproval-v1-java",
    deps = [
        ":accessapproval_java_gapic",
        ":accessapproval_java_grpc",
        ":accessapproval_java_proto",
        ":accessapproval_proto",
    ],
    include_samples = True,
)

Not including (as currently is) will result in no samples being included allowing us to roll out slower. This isn't whether samples will be generated but whether they would be included in the assembly package, that would require a more complicated change.

Follow up to: cl/446288272

@eaball35
chore: avoid using implictly declared target
5722ce6 
Now to include samples in the package we have to pass includeSamples = True in the build file such as:

java_gapic_assembly_gradle_pkg(
    name = "google-cloud-accessapproval-v1-java",
    deps = [
        ":accessapproval_java_gapic",
        ":accessapproval_java_grpc",
        ":accessapproval_java_proto",
        ":accessapproval_proto",
    ],
    includeSamples = True,
)
@eaball35 eaball35 requested review from a team as code owners May 18, 2022 04:51
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 18, 2022
@eaball35 eaball35 changed the title chore: avoid using implicitly declared samples target chore: avoid using implicitly declared samples target in build May 18, 2022
@eaball35 eaball35 changed the title chore: avoid using implicitly declared samples target in build chore: avoid using implicitly declared samples target in BUILD May 18, 2022
@eaball35 eaball35 changed the title chore: avoid using implicitly declared samples target in BUILD chore: avoid using implicitly declared samples target in BUILD.bazel May 18, 2022
vam-google
vam-google approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please change the name of the new param to include_samples to match bazel naming convention

rules_java_gapic/java_gapic_pkg.bzl Outdated
@@ -317,6 +317,7 @@ java_gapic_srcs_pkg = rule(
def java_gapic_assembly_gradle_pkg(
name,
deps,
includeSamples = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use snake_case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@eaball35 eaball35 merged commit 1aac2f9 into main May 21, 2022
@eaball35 eaball35 deleted the emily-branch branch May 21, 2022 00:00
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@eaball35
chore: avoid using implicitly declared samples target in BUILD.bazel (#…
d9d3a18 
…994)

* chore: avoid using implictly declared target

Now to include samples in the package we have to pass includeSamples = True in the build file such as:

java_gapic_assembly_gradle_pkg(
    name = "google-cloud-accessapproval-v1-java",
    deps = [
        ":accessapproval_java_gapic",
        ":accessapproval_java_grpc",
        ":accessapproval_java_proto",
        ":accessapproval_proto",
    ],
    includeSamples = True,
)

* use snake case
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
6bda7ce 
….6.6 (#994)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.4` -> `1.6.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.6/compatibility-slim/1.6.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.6/confidence-slim/1.6.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.6`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;166-httpsgithubcomgoogleapisjava-iamcomparev165v166-2022-10-25)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.5...v1.6.6)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.5 ([#&#8203;489](https://togithub.com/googleapis/java-iam/issues/489)) ([ab8be40](https://togithub.com/googleapis/java-iam/commit/ab8be4088259b25799aa5df0e7cfe944a7da7956))

### [`v1.6.5`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;165-httpsgithubcomgoogleapisjava-iamcomparev164v165-2022-10-24)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.4...v1.6.5)

##### Dependencies

-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20221016-2.0.0 ([#&#8203;479](https://togithub.com/googleapis/java-iam/issues/479)) ([728084c](https://togithub.com/googleapis/java-iam/commit/728084cba18609a511dd04d67a59a8b0a4c2a63d))
-   Update dependency com.google.auth:google-auth-library-oauth2-http to v1.12.1 ([#&#8203;478](https://togithub.com/googleapis/java-iam/issues/478)) ([94e2ca1](https://togithub.com/googleapis/java-iam/commit/94e2ca1930ec67bf1d837e044c8a72d64b6eae45))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#&#8203;486](https://togithub.com/googleapis/java-iam/issues/486)) ([292042e](https://togithub.com/googleapis/java-iam/commit/292042ea315d3bff5b07e86b73d82fa290364a8a))
-   Update dependency com.google.cloud:google-iam-policy to v1.6.4 ([#&#8203;475](https://togithub.com/googleapis/java-iam/issues/475)) ([b86f46c](https://togithub.com/googleapis/java-iam/commit/b86f46cd9115b5d07d867766e37d402d054768a2))
-   Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#&#8203;481](https://togithub.com/googleapis/java-iam/issues/481)) ([cb74130](https://togithub.com/googleapis/java-iam/commit/cb741301c1add6eb5e790de44caa7961e2ea055d))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.8 ([#&#8203;482](https://togithub.com/googleapis/java-iam/issues/482)) ([176de6c](https://togithub.com/googleapis/java-iam/commit/176de6cb499db8fde987f69df35038d9872fad25))
-   Update dependency io.grpc:grpc-protobuf to v1.50.0 ([#&#8203;476](https://togithub.com/googleapis/java-iam/issues/476)) ([358383f](https://togithub.com/googleapis/java-iam/commit/358383fef13874226454c05464a615651ec5b0fb))
-   Update dependency io.grpc:grpc-protobuf to v1.50.2 ([#&#8203;483](https://togithub.com/googleapis/java-iam/issues/483)) ([3c9999b](https://togithub.com/googleapis/java-iam/commit/3c9999b9b4daca5aa343005ca89055f7172ba2dc))
-   Update dependency io.grpc:grpc-stub to v1.50.2 ([#&#8203;477](https://togithub.com/googleapis/java-iam/issues/477)) ([e2255ec](https://togithub.com/googleapis/java-iam/commit/e2255ecfe43a7aef250802cd1829771d4b3691d8))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzMi4yNDEuMTEifQ==-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore(main): release 2.8.24 (#996)
7a92143 
🤖 I have created a release *beep* *boop*
---


## [2.8.24](https://togithub.com/googleapis/java-core/compare/v2.8.23...v2.8.24) (2022-10-26)


### Dependencies

* Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.6 ([#994](https://togithub.com/googleapis/java-core/issues/994)) ([6bda7ce](https://togithub.com/googleapis/java-core/commit/6bda7ce63b19eb44add041482edd1e3de1100cad))
* Update dependency com.google.code.gson:gson to v2.10 ([#995](https://togithub.com/googleapis/java-core/issues/995)) ([0244ed8](https://togithub.com/googleapis/java-core/commit/0244ed8813ba261f416014cf1eff7a267de23013))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@vam-google vam-google vam-google approved these changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eaball35 @blakeli0 @vam-google