Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid using implicitly declared samples target in BUILD.bazel #994

Merged
merged 2 commits into from
May 21, 2022
Merged

chore: avoid using implicitly declared samples target in BUILD.bazel #994

merged 2 commits into from
May 21, 2022

Commits on May 18, 2022

  1. chore: avoid using implictly declared target 

    Now to include samples in the package we have to pass includeSamples = True in the build file such as:

java_gapic_assembly_gradle_pkg(
    name = "google-cloud-accessapproval-v1-java",
    deps = [
        ":accessapproval_java_gapic",
        ":accessapproval_java_grpc",
        ":accessapproval_java_proto",
        ":accessapproval_proto",
    ],
    includeSamples = True,
)
    @eaball35
    eaball35 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5722ce6 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. use snake case

    @eaball35
    eaball35 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    b39900c View commit details
    Browse the repository at this point in the history