Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update actions/upload-artifact and actions/download-artifact #1910

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 14, 2023

https://github.com/actions/upload-artifact/releases/tag/v4.0.0
https://github.com/actions/download-artifact/releases/tag/v4.0.0

There are breaking changes in upload-artifact v4 where the artifact name must be different. See https://github.com/actions/toolkit/tree/main/packages/artifact#breaking-changes

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once.

I tested the changes in googleapis/python-pubsublite#466

@parthea parthea requested a review from a team as a code owner December 14, 2023 17:27
@parthea parthea marked this pull request as draft December 14, 2023 18:36
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 14, 2023
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 14, 2023
@parthea parthea marked this pull request as ready for review December 14, 2023 22:01
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with this!

@parthea parthea merged commit 280ddae into master Dec 14, 2023
12 checks passed
@parthea parthea deleted the parthea-patch-2 branch December 14, 2023 22:12
parthea added a commit to renovate-bot/google-cloud-python that referenced this pull request Dec 18, 2023
parthea added a commit to renovate-bot/proto-plus-python that referenced this pull request Jan 8, 2024
parthea added a commit to renovate-bot/proto-plus-python that referenced this pull request Jan 8, 2024
parthea added a commit to renovate-bot/proto-plus-python that referenced this pull request Jan 25, 2024
parthea added a commit to googleapis/proto-plus-python that referenced this pull request Jan 25, 2024
* chore(deps): update all dependencies

* See googleapis/synthtool#1910

* See googleapis/synthtool#1910

---------

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants