Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update actions/upload-artifact and actions/download-artifact #1910

Merged
merged 2 commits into from
Dec 14, 2023
Merged

build: update actions/upload-artifact and actions/download-artifact #1910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7c5be
build: update actions/upload-artifact and actions/download-artifact
parthea Dec 14, 2023
6fda825
cater for breaking changes in v4
parthea Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions synthtool/gcp/templates/python_library/.github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ jobs:
run: |
nox -s unit-${{ '{{' }} matrix.python {{ '}}' }}
- name: Upload coverage results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage-artifacts
name: coverage-artifact-${{ '{{' }} matrix.python {{ '}}' }}
path: .coverage-${{ '{{' }} matrix.python {{ '}}' }}

cover:
Expand All @@ -47,11 +47,11 @@ jobs:
python -m pip install --upgrade setuptools pip wheel
python -m pip install coverage
- name: Download coverage results
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage-artifacts
path: .coverage-results/
- name: Report coverage results
run: |
coverage combine .coverage-results/.coverage*
find .coverage-results -type f -name '*.zip' -exec unzip {} \;
coverage combine .coverage-results/**/.coverage*
coverage report --show-missing --fail-under={{ cov_level if cov_level != None else 100 }}
Loading