Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): relax license header replacement regex and use current year #383

Merged
merged 3 commits into from Jan 22, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 22, 2020

Update the fixed license headers to use the current year. Generated sources from protoc and grpc do not include license headers so synthtool currently injects them as part of the pipeline. It also fixes the formatting of the header from the gapic-generator for resource name classes.

Added link to issue filed on gapic-generator for the header formatting: googleapis/gapic-generator#3074

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2020
Copy link
Contributor

@SurferJeffAtGoogle SurferJeffAtGoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works against the principle of reproducible builds. Building with the exact same tools and the same source files will yield different output if the date changes.

@chingor13 chingor13 merged commit 4687976 into googleapis:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants