Prepare to Firebase 3 upgrade #158
Conversation
jpventura
force-pushed
the
prepare_to_firebase_upgrade
branch
2 times, most recently
from
4974487
to
7e4d073
Compare
Travis CI is falling because it is not finding npm and karma-cli in order to perform the tests (seems like they are not installed on the VMs). We just need configure before_install option at .travis.yml, ensuring that packages are present before starting the unit tests.
Minor .gitignore upgrade: - Remove duplicated folders - Upgrade list of automatically created files that should be ignored - Use GitHub Node.js .gitignore template (see https://goo.gl/hx0XE) - Also ignore Emacs and VSCode automatic files
Update required in order to Travis CI run the unit tests
Updated all package dependencies to its latest version, except Firebase and Backbone. This is an intermediary step before actually upgrading to latest backend version. Removed gulp-server and use gulp-contrib-connect instead (updating Gruntfile.js task also is required to perform the unit tests). We also installed chai and sinon because they are required by karma-chai and karma-sinon respectivelly.
Fix Backbone.Firebase.Collection#fetch test to properly check if a collection was successfully synced with Firebase backend.
jpventura
force-pushed
the
prepare_to_firebase_upgrade
branch
from
7e4d073
to
df6ee2d
Compare
|
Has this been merged into master? Doesn't look like it. Should I use this branch if I want to work with V3? |
|
@dwhipps Nope. I tried getting contact with Firebase reviewers on Twitter as well, but seems like the project was abandoned |
|
@AbeHaskins, @davideast, @jwngr Is the project still active? |
|
If you need we can get this library upgraded to Firebase 4.6.0. However, do know that this library doesn't get much support due to it's usage. It currently does 16 downloads per month. |
|
It'd be awesome to get this upgraded. While Backbone isn't getting that much attention these days, this may be more popular than 16 downloads per month. Many Backbone users (such as myself) may not be using npm and may just download the files from the repo directly, or even link straight to the CDN. |
|
@davideast Yes, I can. This PR in special was only to get Travis CI working again for future pull requests. Once it is merged, I could finish the refactor to Firebase 4.6.0. Doest it make sense? |
|
@wuservices According to NPM Stat, it never was a popular library (at most 50 downloads/month), while AngularFired reached 7731 downloads/month. So must I agree with @davideast about Firebase team do not spend time supporting in a package with no demand (if compared to all other Firebase JS libraries). But I see no reason why the community could not maintain it 😄. |
jpventura
force-pushed
the
prepare_to_firebase_upgrade
branch
from
bacdf3f
to
df6ee2d
Compare
These modifications are preparatory steps before actually updating the project to the latest Firebase and Backbone versions:
npmandkarma-cliin order to perform the tests (seems like they are not installed on the VMs).before_installoption at.travis.yml, ensuring that packages are present before starting the unit tests.Fix: #157