-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(help-text): improve help text #3901
Conversation
Update help text meta-description audit to be more consistent with the other audits.
Thanks so much for the first-time contribution @daannijkamp! The cc @rviscomi @kdzwinel I'm assuming the break from the norm on these was intentional? :) |
Some more information why I suggested this:
|
If you do want to change the link to "Learn more", you also need to rewrite the sentence. As this PR is currently written, it will say "Read more in the Learn more". 🙈
Yes, I'd prefer more descriptive text. But I realize that most of the LH audits are written as "Learn more" so I'd also be fine with making it more consistent. |
Ah thanks for the additional context @daannijkamp. Recently there came up a different need (#3844) to have dedicated docs link property on the audit too, and the additional translation benefit point you make is a good one. We'll have to weigh that against the concern of polluting the audit property list with an unmanageable set of names, but a good idea to consider. As for this PR specifically, if Rick is fine with consistency here and this is really the only standout, this change (sentence fixing aside) seems reasonable to me until we make all help text descriptive. cc @paulirish who more strongly felt we should move away from "Learn more" |
Assuming the thumbs up on Rick's comment means you're cool with this @paulirish :) thanks again @daannijkamp! |
Update help text meta-description audit to be more consistent with the other audits.