-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(load-fast-4-pwa): use computed artifacts #4981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % nits
const MAXIMUM_TTFI = 10 * 1000; | ||
|
||
const WHITELISTED_STATUS_CODES = [307]; | ||
const MAXIMUM_TTI = 10 * 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to call out explicitly:
We're changing the PWA speed threshold from TTFI <= 10s
to be a slightly more aggressive TTI < 10s
.
const metricComputationData = {trace, devtoolsLog, settings}; | ||
const tti = await artifacts.requestConsistentlyInteractive(metricComputationData); | ||
|
||
const score = Number(tti.timing <= MAXIMUM_TTI); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developers.google.com/web/progressive-web-apps/checklist does say
interactive <10s for first visit on a simulated 3G network.
let's change this to <
just to simplify. nice to stay single digits. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg :)
const trace = artifacts.traces[Audit.DEFAULT_PASS]; | ||
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS]; | ||
const settingOverrides = {throttlingMethod: 'simulate', throttling: mobile3GThrottling}; | ||
const settings = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you drop a comment for this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good call done
means we'll never pass with the caveat :D we can always answer the question!