core(metrics): add lantern EIL #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Apr 24, 2018
| const settings = {throttlingMethod: 'simulate'}; | ||
| const result = await artifacts.requestEstimatedInputLatency({trace, devtoolsLog, settings}); | ||
|
|
||
| assert.equal(Math.round(result.timing), 104); |
There was a problem hiding this comment.
this is a legitimate difference, basically the original trace has ~400ms of mainthread work that escapes in the freebie 500ms of a 5s window, in Lantern this gets 4x'd and isn't hidden anymore
brendankenny
approved these changes
Apr 26, 2018
| @@ -7,16 +7,7 @@ | |||
|
|
|||
| const Audit = require('./audit'); | |||
| const Util = require('../report/v2/renderer/util'); | |||
| const TracingProcessor = require('../lib/traces/tracing-processor'); | |||
There was a problem hiding this comment.
I think the conflict is just v2/ -> html/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lantern implementation of estimated input latency and moves the metric to a computed artifact. The coefficients are currently best guess. I'll do one final pass for coeffs on all other metrics since the 3 original haven't been tweaked in many iterations, but accuracy stats unfortunately unavailable since we just introduced this rolling window metric in v3 as well. This is the only non-lantern metric ATM and seems worth giving a try to evaluate later
ref #5008