-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(metrics): add lantern EIL #5024
Conversation
const settings = {throttlingMethod: 'simulate'}; | ||
const result = await artifacts.requestEstimatedInputLatency({trace, devtoolsLog, settings}); | ||
|
||
assert.equal(Math.round(result.timing), 104); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a legitimate difference, basically the original trace has ~400ms of mainthread work that escapes in the freebie 500ms of a 5s window, in Lantern this gets 4x'd and isn't hidden anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -7,16 +7,7 @@ | |||
|
|||
const Audit = require('./audit'); | |||
const Util = require('../report/v2/renderer/util'); | |||
const TracingProcessor = require('../lib/traces/tracing-processor'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the conflict is just v2/
-> html/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
Adds a lantern implementation of estimated input latency and moves the metric to a computed artifact. The coefficients are currently best guess. I'll do one final pass for coeffs on all other metrics since the 3 original haven't been tweaked in many iterations, but accuracy stats unfortunately unavailable since we just introduced this rolling window metric in v3 as well. This is the only non-lantern metric ATM and seems worth giving a try to evaluate later
ref #5008