tests: fix cli handling empty runnerResult during gatherMode #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Apr 27, 2018
brendankenny
approved these changes
Apr 27, 2018
| const cwd = process.cwd(); | ||
| let promise = Promise.resolve(); | ||
|
|
||
| const shouldSaveResults = flags.auditMode || (flags.gatherMode === flags.auditMode); | ||
| if (!shouldSaveResults) return promise; | ||
| const {lhr, artifacts} = runnerResult; |
There was a problem hiding this comment.
clearly we need type checking in here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the destructure in
saveResultsbroke cases where gatherMode existed runner early with anundefinedrunnerResultplenty of others ways to solve this. happy to do them, though this seemed like the most non-invasive.
driveby fix: avoid comparing
outputmuch like gather/auditMode as theoutputis irrelevant to a gather run.