report: add auditIds to DOM. update pptr tests to assert against them. #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested review from
ebidel,
patrickhulce and
vinamratasingal-zz
as code owners
brendankenny
approved these changes
Apr 27, 2018
| @@ -30,6 +30,7 @@ class CategoryRenderer { | |||
| renderAudit(audit) { | |||
| const tmpl = this.dom.cloneTemplate('#tmpl-lh-audit', this.templateContext); | |||
| const auditEl = this.dom.find('.lh-audit', tmpl); | |||
| auditEl.id = audit.result.name; | |||
There was a problem hiding this comment.
this won't be unique if we do the key/name split, but we can probably cross that bridge when we come to it since we don't have an alternative name at this point
paulirish
changed the title
paulirish
changed the title
kdzwinel
pushed a commit
to kdzwinel/lighthouse
that referenced
this pull request
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audit ids making it far more clear:
Failure that ward, brendan and me faced before:
New failure:
