core(scoring): tweak performance weights #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
May 1, 2018
| {id: 'interactive', weight: 5, group: 'perf-metric'}, | ||
| {id: 'speed-index', weight: 1, group: 'perf-metric'}, | ||
| {id: 'estimated-input-latency', weight: 1, group: 'perf-metric'}, | ||
| {id: 'first-cpu-idle', weight: 2, group: 'perf-metric'}, |
There was a problem hiding this comment.
nbd but why did the order change?
There was a problem hiding this comment.
oh just aligning more with the order presented over there, I have no opinion I can revert
brendankenny
approved these changes
May 2, 2018
|
BY ORDER OF THE COMMITTEE |
paulirish
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4629
tweaks the performance score weights according to https://docs.google.com/document/d/1XiKdkLgWul0l40slhkCmQufNdjUiTlq3H_EAjrBH5Cw/edit#
I ran the weights and new thresholds for what we have in HTTPArchive and got the distribution, it's pretty aggressive.
Median: 27
75th Percentile: 43
90th Percentile: 69
95th Percentile: 83
99th Percentile: 98
Roughly 3% of sites get a 90+
Roughly 0.08% of sites get a 100
I'm disappointed new rolling window EIL won't get any credit, but that'll give us time to take a look at the distribution of the new definition and adjust score thresholds without impacting the overall perf score, and this is aggressive enough as it is :)