-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(scoring): tweak performance weights #5083
Conversation
{id: 'interactive', weight: 5, group: 'perf-metric'}, | ||
{id: 'speed-index', weight: 1, group: 'perf-metric'}, | ||
{id: 'estimated-input-latency', weight: 1, group: 'perf-metric'}, | ||
{id: 'first-cpu-idle', weight: 2, group: 'perf-metric'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nbd but why did the order change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh just aligning more with the order presented over there, I have no opinion I can revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the golden LHR it looks like, but otherwise LGTMmmmm
BY ORDER OF THE COMMITTEE |
closes #4629
tweaks the performance score weights according to https://docs.google.com/document/d/1XiKdkLgWul0l40slhkCmQufNdjUiTlq3H_EAjrBH5Cw/edit#
I ran the weights and new thresholds for what we have in HTTPArchive and got the distribution, it's pretty aggressive.
Median: 27
75th Percentile: 43
90th Percentile: 69
95th Percentile: 83
99th Percentile: 98
Roughly 3% of sites get a 90+
Roughly 0.08% of sites get a 100
I'm disappointed new rolling window EIL won't get any credit, but that'll give us time to take a look at the distribution of the new definition and adjust score thresholds without impacting the overall perf score, and this is aggressive enough as it is :)