core(lhr): rename perf-hint, perf-info, etc #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested review from
brendankenny,
ebidel,
patrickhulce and
vinamratasingal-zz
as code owners
patrickhulce
reviewed
May 3, 2018
| infoAudits.forEach(item => infoAuditsEl.appendChild(this.renderAudit(item))); | ||
| infoAuditsEl.open = true; | ||
| element.appendChild(infoAuditsEl); | ||
| const diagAudits = category.audits |
There was a problem hiding this comment.
does diagnosticAudits push this over line limits? diag is a bit more of a stretch IMO :)
| hintAudits.forEach(item => hintAuditsEl.appendChild(this._renderPerfHintAudit(item, scale))); | ||
| hintAuditsEl.open = true; | ||
| element.appendChild(hintAuditsEl); | ||
| const oppsEl = this.renderAuditGroup(groups['load-opportunities'], {expandable: false}); |
There was a problem hiding this comment.
might as well go with groupEl at this point :)
| @@ -1131,7 +1131,7 @@ | |||
| { | |||
| "id": "first-meaningful-paint", | |||
| "weight": 5, | |||
| "group": "perf-metric", | |||
There was a problem hiding this comment.
what uses this, does it really need to be updated?
patrickhulce
reviewed
May 3, 2018
| const diagnosticAudits = category.audits | ||
| .filter(audit => audit.group === 'diagnostics' && audit.result.score < 1); | ||
| if (diagnosticAudits.length) { | ||
| const diagsEl = this.renderAuditGroup(groups['diagnostics'], {expandable: false}); |
There was a problem hiding this comment.
I meant groupEl here too :)
patrickhulce
reviewed
May 3, 2018
| @@ -153,30 +154,30 @@ class PerformanceCategoryRenderer extends CategoryRenderer { | |||
| element.appendChild(metricAuditsEl); | |||
|
|
|||
| // Opportunities | |||
| const hintAudits = category.audits | |||
| .filter(audit => audit.group === 'perf-hint' && audit.result.score < 1) | |||
| const oppAudits = category.audits | |||
There was a problem hiding this comment.
does opportunityAudits not fit? :D
patrickhulce
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change to the config:
perf-metric=>metricsperf-hint=>load-opportunitiesperf-info=>diagnosticsUpdated report classnames, and renderer method names.
ref #5008