core(lantern): never exclude main document from graphs #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 16cf671.
patrickhulce
changed the title
|
@paulirish @brendankenny no longer WIP, it's 10/10 so far on passing extension test so lookin' good |
patrickhulce
commented
May 4, 2018
| * @return {LH.WebInspector.NetworkRequest} | ||
| */ | ||
| static findMainDocument(records) { | ||
| // TODO(phulce): handle more edge cases like client redirects, or plumb through finalUrl |
There was a problem hiding this comment.
adding finalUrl to all calls of request* is just insane work atm, should be easier after a refactor to pass in artifacts and make that dance a little easier
|
if you fellas wanna take a look we can have a lot more green builds ;) |
brendankenny
approved these changes
May 4, 2018
There was a problem hiding this comment.
LGTM
I'm kind of worried this is a future potential issue if we don't always remember to get the main resource in a graph, but it's also reasonable to want to take subgraphs that don't have the main resource in it. So I'm not sure how to make the correct way the default way without making usability awkward in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix the travis flake we've been seeing on extension tests
cannot find node ID 02u309rjfja0fsdjflajsfd