core(tsc): fix OptimizedImages type; type check dep audits #5129
Conversation
| /** @typedef {{isSameOrigin: boolean, isBase64DataUri: boolean, requestId: string, url: string, mimeType: string, resourceSize: number}} SimplifiedNetworkRecord */ | ||
| results.push({ | ||
| failed: false, | ||
| ...stats, |
| const failedImages = []; | ||
| /** @type {Array<{url: string, fromProtocol: boolean, isCrossOrigin: boolean, totalBytes: number, wastedBytes: number}>} */ |
There was a problem hiding this comment.
since this is used in multiple audits can we share it? i'm okay either way.
There was a problem hiding this comment.
it's almost but not quite the same as we use in other audits, enough to be annoying to redefine. url has to be a string and there's the extra isCrossOrigin and fromProtocol properties. I don't think it's worth defining externally for just this and uses-optimized-images, though, since it just becomes a ByteEfficiencyResult to the rest of the pipeline
There was a problem hiding this comment.
I can make the failedImages type be inferred, though
|
|
||
| for (const record of imageRecords) { | ||
| try { | ||
| const stats = await this.calculateImageStats(driver, record); |
There was a problem hiding this comment.
throwing this out there... maybe we should let these race and promise.all them instead. would probably be faster.
but i cant remember if I've seen this gatherer being particularly slow..
There was a problem hiding this comment.
it can definitely be slow, but in the cases where it's slowest (few cores, slow CPU) asking chrome to simultaneously compress all of them at once isn't going to help :)
I think it's pretty readable as is, Promise.all might mess with try/catch clarity
There was a problem hiding this comment.
k sg. then yah nvm. we'll keep it running serially.
|
Yet another browserify syntax error. It's on object spread again, this time in lexical-scope, called by insert-module-globals. It appears it might be an actual bug, though, and not another parser version that needs to be piped through because you can actually use object spread in some files and not others. e.g. not in |
|
gave up on fixing object spread for now and filed #5152 :) Have to |
make
OptimizedImagesa discriminated union onfailedor not. Keeps the artifact type simpler and the use of it really simple in these two audits.The only remaining
// @ts-nocheckaudit ismixed-content.js, which should make refactors a little more easier.