report(i18n): localize CRC renderer strings #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slight change to make translation easier. before: after: (edit) more after: |
24 tasks
paulirish
force-pushed
the
i18n_crc_strings
branch
from
3629f13
to
cab03fc
Compare
paulirish
force-pushed
the
i18n_crc_strings
branch
from
cab03fc
to
aa43d3b
Compare
brendankenny
approved these changes
Aug 2, 2018
| @@ -405,6 +396,11 @@ Util.UIStrings = { | |||
| toplevelWarningsMessage: 'There were issues affecting this run of Lighthouse:', | |||
| /** Label preceding a pictorial explanation of the scoring scale: 0-50 is red (bad), 50-90 is orange (ok), 90-100 is green (good). These colors are used throughout the report to provide context for how good/bad a particular result is. */ | |||
| scorescaleLabel: 'Score scale:', | |||
|
|
|||
| /** String of text shown in a graphical representation of the flow of network requests for the web page. This label represents the initial network request that fetches an HTML page. This navigation may be redirected (eg. Initial navigation to http://example.com redirects to https://www.example.com). */ | |||
There was a problem hiding this comment.
the redirected explanation may be overkill but w/e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the text is actually just the path and origin of each request so there wasn't actually that much here.